Upstream sync 10D: shader recompiler slice (7 commits) - #492

Sync 10 slice D: shader recompiler

Cherry-picks (-x) from d8888df9b..upstream/main, scopes shader, recompiler and structurizer. ShaderDiskCache payload layout is unchanged, so FormatVersion is not bumped.

Ported (7)

• fix(shader): plan a table T# that several image operations share
• test(shader): check that a queried and sampled table T# is one image
• test(shader): check uniform table images after the descriptor phis (moves the existing test function; no behaviour change)
• feat(recompiler): reuse pure IR values recomputed in dominated blocks (new RedundantValueEliminator pass, run after interface preparation; adds agc_redundant_value_elimination_tests)
• fix(shader): size per-invocation LDS by the append counter's offset
• fix(shader): record BDA faults in hull programs instead of refusing them (only the refusal removal and the contract test; the Vulkan Tessellation.cpp execution-test hunks conflict with main's version and were not taken)
• fix(shader): normalize reserved buffer bits before scalar binding (the Vulkan BufferDescriptorRuntime.cpp test does not exist on main and was not taken). The "Scalar buffer descriptors" entry from the earlier scalar-load commit was added to docs/dev/TechnicalDebt.md here, because that entry was missing from main.

Skipped

• Already on main (code present, equivalent or identical): load the PERSP_SAMPLE and LINEAR_SAMPLE I/J pairs, update per-invocation LDS without atomics, capture image descriptors read from constant buffers at uniform offsets (only an already-present test duplicate remained), read lane 63 of half-wave reductions and its search-order test, structurize refused control flow with reach flags and its test, post-order structurizer fixpoints with the growth budget and its test, take a hull's input stride from its patch term, adjacent BDA dword loads through one span read, 32_AR export alpha from channel 1, split variant compilation into interface and emission steps, emit both registration layouts of a pixel shader, the TStep style rename, ignore unused descriptor fields for scalar buffer loads.
• User-data tail linking (raw vertex prologs and fragment tails, plus the vertex tail state test): the feature does not exist on main. The driver glue conflicts with the backend-neutral DecodeDrawPrograms in DrawDispatch.cpp and the Metal draw path, so it needs its own port.
• fix(shader): lower hulls that write one output control point per patch: TessellationLowering.cpp on main lacks the evaluator and record helpers it builds on (they come with agc-scope hull work); two conflicting hunks.
• perf(shader): map cached SPIR-V from the shader cache files, and fix(shader): map shader cache files on Windows: conflicts in nine files (ShaderDiskCache, VulkanDevice.cpp, tests deleted on main); performance only, Windows part not applicable.
• fix(shader): share delete access when reading cache entries on Windows: Windows only.
• Waterfall descriptors (feat(recompiler): plan waterfall loops over per-lane T#s as non-uniform tables boykopovar/AnyPS5#5089) and its follow-ups (plan waterfall loops over per-lane T#s, refuse per-lane tables over masked T#s, no record of empty per-lane tables, preserve per-lane table modes in disk plans, disk format 32), together with its revert (Revert #5089: agc_driver_waterfall_images fails SPIR-V validation on main boykopovar/AnyPS5#5824): upstream reverted it, so both sides are skipped.
• feat(tools): compile the changed translation units only: tooling, not a recompiler change.
• agc-scope commits touching core/shader (hull patch index, 2D-array image access on 3D T#, dithered alpha coverage, mesh clip/cull distances): belong to the AGC driver slice.

Evidence

• x86_64 ANYPS5_ROSETTA_LIBS=ON build (nice -n 10, 4 jobs) of rosetta_libs rosetta_engine succeeded.
• core/libs/prx/libSceAgcDriver/tests/RedundantValueElimination.cpp built standalone against the recompiler sources (clang++ -O0, the disk cache and SPIR-V optimizer pieces stubbed or left out) and exits 0.
• ResourceTracker.cpp, ResourceMaterializer.cpp, Recompiler.cpp, SpirvAnalysis.cpp, SpirvBdaRead.cpp, ShaderMemory.cpp and BdaContracts.cpp pass clang++ -std=c++20 -fsyntax-only.
• Game smoke (tools/smoke.sh <build> 300 --map): main menu <= 65 s, leader select <= 77 s, map generation start <= 98 s, 2069 frames presented, no fault or uncaught exception, shader disk cache 0 load failures and 0 write failures.
• Not run: the agc_driver_* execution tests (they need a Vulkan test device), the metal shader bridge ctest (that configuration does not compile the recompiler), the Metal shader converter on output of the new value-elimination pass beyond what the smoke exercised.
• No performance claims.

🤖 Generated with Claude Code